Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prevent text wrap in department/school card #1055

Merged
merged 2 commits into from
Dec 22, 2024
Merged

feat: prevent text wrap in department/school card #1055

merged 2 commits into from
Dec 22, 2024

Conversation

KevinWu098
Copy link
Member

Summary

  1. School & Dept cards will no longer wrap on smaller screens, reducing UI shift

chrome-capture-2024-10-22 (1)

Test Plan

  1. View the dept/school card on a variety of screen sizes (mobile, desktop, desktop with a small course pane)
  2. Ensure no text wraps
  3. Ensure the other parts of the accordion still function as expected (opens, content is readable)

Issues

Closes #729

MinhxNguyen7
MinhxNguyen7 approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@MinhxNguyen7 MinhxNguyen7 merged commit 8aac492 into main Dec 22, 2024
4 checks passed
@MinhxNguyen7 MinhxNguyen7 deleted the kwu/prevent-text-wrap-school-dept-card branch December 22, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinhxNguyen7 MinhxNguyen7 MinhxNguyen7 approved these changes

@adcockdalton adcockdalton Awaiting requested review from adcockdalton

Assignees
No one assigned
Labels
None yet
Projects
AntAlmanac
Status: Done 🤩
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent Text-Wrap in SectionTableBody and the Department Card Component
2 participants
@KevinWu098 @MinhxNguyen7